Code Review for 6136-sysmacros.h-unnecessarily-polutes-the-namespace

Prepared by: (jeffpc) on 2015-Aug-18 16:13 -0400 EDT
Workspace:/home/jeffpc/illumos/sysmacros (at f1a77509c8c2)
Compare against: HEAD^ (at 4cfd297a2861)
Summary of changes: 58 lines changed: 8 ins; 49 del; 1 mod; 20423 unchg
Patch of changes: 6136-sysmacros.h-unnecessarily-polutes-the-namespace.patch
Printable review: 6136-sysmacros.h-unnecessarily-polutes-the-namespace.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/devfsadm/fssnap_link.c 

6136 sysmacros.h unnecessarily polutes the namespace
3 lines changed: 1 ins; 2 del; 0 mod; 86 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/ufs/fsdb/fsdb.c 

6136 sysmacros.h unnecessarily polutes the namespace
1 line changed: 1 ins; 0 del; 0 mod; 5326 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fuser/fuser.c 

6136 sysmacros.h unnecessarily polutes the namespace
3 lines changed: 1 ins; 2 del; 0 mod; 593 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sendmail/src/queue.c 

6136 sysmacros.h unnecessarily polutes the namespace
2 lines changed: 2 ins; 0 del; 0 mod; 8930 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sendmail/src/util.c 

6136 sysmacros.h unnecessarily polutes the namespace
2 lines changed: 2 ins; 0 del; 0 mod; 2854 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/brand/solaris10/s10_brand/common/s10_brand.c 

6136 sysmacros.h unnecessarily polutes the namespace
1 line changed: 1 ins; 0 del; 0 mod; 2187 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/mkdev.h 

6136 sysmacros.h unnecessarily polutes the namespace
7 lines changed: 0 ins; 7 del; 0 mod; 100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/sysmacros.h 

6136 sysmacros.h unnecessarily polutes the namespace
39 lines changed: 0 ins; 38 del; 1 mod; 347 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.